Support Ubuntu and Debian-derived OS using ID_LIKE in /etc/os-release #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #328 |
natanjunges
suggested changes
Jul 16, 2022
This was referenced Jul 17, 2022
Merged
|
should also work for #327 because neon has |
|
This broke The code provided by this PR then replaces function deb_copyq() {
if [ "${UPSTREAM_ID}" == "ubuntu" ]; then
PPA="ppa:hluk/copyq"
PRETTY_NAME="CopyQ"
WEBSITE="https://hluk.github.io/CopyQ/"
SUMMARY="An advanced clipboard manager with editing and scripting features."
fi
}making it impossible to update or install packages from PPAs : sudo deb-get install copyq
[!] ERROR! Download URL for copyq is empty. Skipping. |
mrm48
pushed a commit
to mrm48/deb-get
that referenced
this pull request
Jul 21, 2022
…wimpysworld#343) * Support Ubuntu and Debian-derived OS using ID_LIKE in /etc/os-release * Revert end of case correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Pop!_OS 22.04, this should extend support to Ubuntu and Debian-derived distros that reference either in the ID_LIKE variable of /etc/os-release. Pop!_OS 22.04 in particular lists both
ID_LIKE="ubuntu debian"in which case only the first is used.