Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Vagrant #532

Merged
merged 1 commit into from Sep 21, 2022
Merged

added Vagrant #532

merged 1 commit into from Sep 21, 2022

Conversation

chriswayg
Copy link
Contributor

re-based in a different branch based on my previous PR: #514

@natanjunges
Copy link
Contributor

You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.

@chriswayg
Copy link
Contributor Author

You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.

I understand and you are right. Its just that I was not that familiar with Github, PRs and doing the requested rebase, that I did not get things right on the first attempt. For example I initially forgot to place the Vagrant PR in a separate branch.

I have in the meantime figured it out and was successful with the merge of Smartgit and I think I got the rebase correct with Packer and Vagrant.

@natanjunges
Copy link
Contributor

No problem, we are all learning.

@flexiondotorg flexiondotorg merged commit 4c94c3f into wimpysworld:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants