Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop ferdium getting nightlies #773

Merged
merged 1 commit into from Apr 26, 2023

Conversation

philclifford
Copy link
Member

or betas. Adding latest to the github sorts it.
So does grep -v
Also the version string needed rework

Closes #772

or betas.  Adding latest to the github sorts it.
So does grep -v
Also the version string needed rework
@abacao
Copy link

abacao commented Mar 27, 2023

👋
I have tested the above implementation locally and it works.

deb-get install ferdium
  [+] Updating /var/cache/deb-get/ferdium.json
/var/cache/deb-get/Ferdium-linux-6.2.6 100%

After the installation and a deb-get update, this error still occurs:

dpkg: error: version 'https://github.com/ferdium/ferdium-app/releases/download/v6.2.6-nightly.9/Ferdium-linux-6.2.6-nightly.9-amd64.deb' has bad syntax: epoch in version is empty

@philclifford
Copy link
Member Author

Thanks for the feedback @abacao, but I'm not seeing that error any more.

I have tested the above implementation locally and it works.

using 99-local.d or how ? (If you edit the definition in the 01-main.d repo manually it'll be replaced when you do a deb-get update)

/var/cache/deb-get/Ferdium-linux-6.2.6 100%

that's not the right release, it's the nightly - I just ran this branch version and installed 6.2.4 without error ...

dpkg: error: version 'https://github.com/ferdium/ferdium-app/releases/download/v6.2.6-nightly.9/Ferdium-linux-6.2.6-nightly.9-amd64.deb' has bad syntax: epoch in version is empty

Clearly didn't use the latest tag or omit the 'nightly' as instructed so I don't think this implementation can have been in effect. If you deb-get show ferdium it will say which definition it uses, and then looking at the mentioned repo : /etc/deb-get/<repo>.d/ferdium will be the implementation in effect.

$ deb-get show ferdium
# %>< snip ><% # 
Ferdium
  Package:	ferdium
  Repository:	91-fixes
  Updater:	deb-get
  Installed:	6.2.4
  Published:	6.2.4
  Architecture:	amd64 arm64
  Download:	https://github.com/ferdium/ferdium-app/releases/download/v6.2.4/Ferdium-linux-6.2.4-amd64.deb
  Website:	https://ferdium.org/
  Summary:	A messaging app for WhatsApp, Facebook Messenger, Slack, Telegram and many many more.

$ grep release /etc/deb-get/91-fixes.d/ferdium 
get_github_releases "ferdium/ferdium-app" latest
#                                         ^^^^^^ 
$ grep URL= /etc/deb-get/91-fixes.d/ferdium 
    URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | grep -v -e nightly -e beta | head -n1 | cut -d'"' -f4)"

$ head -1 /etc/deb-get/91-fixes.repo
https://raw.githubusercontent.com/philclifford/deb-get/extras/91-fixes

The grep -v is really belt-and-braces since latest will not have those they have tagged as pre-release- it is currently only offering 6.2.4

@flexiondotorg flexiondotorg merged commit 0935fd1 into wimpysworld:main Apr 26, 2023
@philclifford philclifford deleted the fix-ferdium branch November 10, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fermium is getting nightlies and version is broken
3 participants