Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Fix detection of desktop packages on non-english systems #15

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Fix detection of desktop packages on non-english systems #15

merged 2 commits into from
Jul 4, 2020

Conversation

lotharsm
Copy link
Contributor

Currently, the script detects the availability of a suitable desktop environment/meta package by searching for the string installed when looking at the packages list.

This will fail on systems that use other languages than English by default. By enforcing LANG=C when launching apt list, we can circumvent this. Tested on a German installation right now.

@codic12
Copy link

codic12 commented Jun 29, 2020

To preserve compatibility with older versions and stay as close to sh as possible, shouldn't env LANG=C be used instead?

@lotharsm
Copy link
Contributor Author

lotharsm commented Jul 1, 2020

Well, I haven't thought about preserving this level of compatibility since at least now we aim at current development builds... How do you want to achieve this with env LANG=C? Setting LANG=C for the entire run of the script?

@codic12
Copy link

codic12 commented Jul 1, 2020

The env command allows you to set env variables for the current command. Example: env X=Y cmd
It's more universally supported on other shells than the classic syntax, as it is an executable (/usr/bin/env on Manjaro), so can be run within other shells...

@codic12
Copy link

codic12 commented Jul 1, 2020

Thanks!

Copy link
Contributor

@RudraSwat RudraSwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work fine.

@flexiondotorg
Copy link
Member

Thanks for fixing this 😃

@flexiondotorg flexiondotorg merged commit 3286d2c into wimpysworld:master Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants