Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAN input length limit #102

Closed
vatara opened this issue Feb 7, 2016 · 3 comments
Closed

SAN input length limit #102

vatara opened this issue Feb 7, 2016 · 3 comments

Comments

@vatara
Copy link
Contributor

vatara commented Feb 7, 2016

Thanks a lot for the work adding SAN support! I did run into an issue though.

I did manual certificate creation and I have quite a few names I want in one certificate. The issue is Console.ReadLine() has a limit of 254 charaters. With all my names, this isn't long enough.

I was able to find a very easy solution that fixed the problem though. I just added
Console.SetIn(new System.IO.StreamReader(Console.OpenStandardInput(8192))); before var SANInput = Console.ReadLine(); in ManualPlugin.cs

After making this change I was able to enter all the hosts and generate the certificate correctly.
rkerber added a commit to rkerber/letsencrypt-win-simple that referenced this issue Feb 8, 2016
@rkerber
SAN/ Cleanup/ RenewalDays/ CertificateStore Work
ba6bf62 
Added RenewalDays config option
Added CertificateStore config option fixes win-acme#98
Fixed some variable names, locations, and protection
Added ObjectExtentions.cs to be able to copy objects so they don't all
get updated.
Changed Manual Plugin sanInput to be able to have a longer input fixes
win-acme#102
Fixed Multiple Site SAN Issue where it was trying to update bindings
that were not there.
@rkerber rkerber mentioned this issue Feb 8, 2016
Merged
@rkerber
Copy link
Collaborator

rkerber commented Feb 8, 2016

This has been added to the latest SAN build.

@rkerber rkerber closed this as completed Feb 8, 2016
@vatara
Copy link
Contributor Author

vatara commented Oct 10, 2016

I'm running into this issue again, when creating a SAN certificate for many sites on the same server. I think the only change needed is adding the
Console.SetIn(new StreamReader(Console.OpenStandardInput(8192))); call to IISSiteServerPlugin.cs. It looks like it was added to the other Plugins, but not this one.

@vatara
Copy link
Contributor Author

vatara commented Oct 10, 2016

Oh, you know never mind. I only ran into this because I was trying to enter the site host names at the prompt instead of the site IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vatara @rkerber