Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward slash is missing in renewal-info path #2498

Closed
grindsa opened this issue Dec 30, 2023 · 3 comments
Closed

Forward slash is missing in renewal-info path #2498

grindsa opened this issue Dec 30, 2023 · 3 comments
Milestone

Comments

@grindsa
Copy link

grindsa commented Dec 30, 2023

Hi,

I am developing a non-letsencrypt acme-proxy and use win-acme during regular regression-testing.

I came across an interoperability issue between my proxy and win-acme. Looking deeper into the problem I noticed that win-acme is constructing the renewal-info path by just adding the base64url-encoded certID to the renewal-info resource.

{renewalInfo url} || certid

The RFC drafts 01 and 02 however require a forward slash between url and certid.

{renewalInfo url} || '/' || certid

Although the problem is not visible when testing against LE (LE sets a forward-slash at the end of the renewal-info resource see below)

grindsa@bumper:~# curl https://acme-v02.api.letsencrypt.org/directory
{
…
  "renewalInfo": "https://acme-v02.api.letsencrypt.org/draft-ietf-acme-ari-01/renewalInfo/",
…
}
grindsa@bumper:~#

It might cause issues with othe acme-server implementations (like mine) who are following the RFC draft more strictly. Thus, it would be good to implement midterm a fix by adding a forward slash between renewalinfo url and certid if its not already part of the renewalinfo url.

Thx
G.

Platform:

  • OS: Windows 10, English
  • win-acme version 2.2.6
@WouterTinus
Copy link
Member

Thanks for the feedback, will do!

@idan100
Copy link

idan100 commented Dec 31, 2023

Hi,
I am having the same bug.
Is there an expected time to the uploading of the fix?

@WouterTinus WouterTinus added this to the 2.2.7 milestone Jan 2, 2024
WouterTinus added a commit to win-acme/ACMESharpCore that referenced this issue Jan 2, 2024
@WouterTinus
Copy link
Member

Fixed in 2.2.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants