Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ImportSQL.ps1 #2458

Merged
merged 2 commits into from Oct 12, 2023
Merged

Conversation

zivillian
Copy link
Contributor

Add script to import certificate into SQL Server (used for encrypted connections). I have successfully tested this on Windows Server 2022 with SQL Server 2022. The import function was originally written by Léon Bouquiet (as mentioned in the script).

Copy link
Member

@WouterTinus WouterTinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some comments on how I think it can be even better, hopefully you're willing to consider them.

dist/Scripts/ImportSQL.ps1 Outdated Show resolved Hide resolved
dist/Scripts/ImportSQL.ps1 Outdated Show resolved Hide resolved
dist/Scripts/ImportSQL.ps1 Outdated Show resolved Hide resolved
@zivillian
Copy link
Contributor Author

I'll do, but this may take a few days.

@WouterTinus WouterTinus merged commit bb2ab48 into win-acme:master Oct 12, 2023
@zivillian zivillian deleted the importsql branch October 15, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants