Add setting to config vault location #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new app setting to allow the config path used to be configurable to per user roaming profile, per user local progile, per machine profile, or arbitrary path.
|
Workaround: #221 (comment) |
|
This will be fixed in v2 with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to allow configuring the config vault location.
Add new app setting to allow the config path used to be configurable to per user roaming profile, per user local profile, per machine profile, or arbitrary path.
I read #146 and noted the issue with email addresses, and potential security problems. Not sure how 0.8 ACEMESharp "profiles" will impact this.
This is the simplest change I could get away with to move the config out of the user profile to a machine level location (we have a admin user who will run this interactively, and a different user for the scheduled task, config needed to be shared).
Regards
Murray