Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve msbuild path form the registry instead of having a static VS… #759

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

Dzoge
Copy link
Contributor

@Dzoge Dzoge commented Feb 22, 2018

Currently MSBuild path is typed statically and Visual studio 2017 community edition is used for that purpose. For those running other versions of VS the build results in an error and requires you to manually edit the build.ps1 file.

I have added a Get-MSBuild-Path (https://stackoverflow.com/a/43623213/573208) to dynamically retrieve MSBuild path during the build process.

@WouterTinus WouterTinus merged commit b988d27 into win-acme:master Feb 22, 2018
@WouterTinus
Copy link
Member

Thanks for that! It's always good to make it easier for people to get involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants