Issues #55 #56 : start convert warning to ValueError and add check #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
macintoshplus
force-pushed
the
issue_55
branch
3 times, most recently
from
5a3c7fe
to
a8c8049
Compare
macintoshplus
changed the title
4 tasks
replace return false bu return if send_parse_paramters fail update changelog change win32_start_service_ctrl_dispatcher error add convert code to exception add Win32ServiceException and use it
macintoshplus
force-pushed
the
issue_55
branch
from
a8c8049
to
c12c423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #55 and #56