Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermium v122 r4 missing 1px divider? #534

Open
Darthagnon opened this issue May 3, 2024 · 8 comments
Open

Supermium v122 r4 missing 1px divider? #534

Darthagnon opened this issue May 3, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@Darthagnon
Copy link

Describe the bug
It's more noticeable when using a custom theme like Simple Silver, but the 1px divider line is now missing, so it's difficult to tell foreground and background tabs apart in Supermium v122 r4

To Reproduce
Steps to reproduce the behavior:

  1. Install Supermium v122 r4
  2. (Optional) Install custom theme, e.g. Simple Silver
  3. Open several tabs
  4. The 1px divider along the top is gone, so background tabs blend into the browser's top chrome

Expected behavior
1px divider line should be present, as in previous releases?

Screenshots
chrome_240503_54

Desktop (please complete the following information):

  • OS: Win10 1709 HiDPI screen
  • Bitness of browser: 64 bit
@Darthagnon Darthagnon added the bug Something isn't working label May 3, 2024
@win32ss
Copy link
Owner

win32ss commented May 3, 2024

I will tweak the tab drawing code to reintroduce this line to all inactive tabs.

@Darthagnon
Copy link
Author

Thank you, win32!

@Anotyx
Copy link

Anotyx commented May 4, 2024

Bez tytułu
@win32ss I know this is kind of a long shot, but since you recreated 'compact mode' for both tabs and omnibox already, could you look into the bookmarks bar too? Currently, with compact UI and legacy omnibox it looks really out of place, taking up as much space as the entire toolbar + ~1/4 of one tab, Could you consider updating it in the future? Me personally would be happy even if it stayed the same but was shrinked a few pixels to match the rest. Thank you!

@Anotyx
Copy link

Anotyx commented May 4, 2024

Bez tytułu
Also, when you start TYPING in the url bar it'll use the new UI.
And yes I know I shouldn't be writing about 2 other issues in someone else's issue, I'm new to github and not experienced enough to create my own, sorry.

@Darthagnon
Copy link
Author

Bez tytułu @win32ss I know this is kind of a long shot, but since you recreated 'compact mode' for both tabs and omnibox already, could you look into the bookmarks bar too? Currently, with compact UI and legacy omnibox it looks really out of place, taking up as much space as the entire toolbar + ~1/4 of one tab, Could you consider updating it in the future? Me personally would be happy even if it stayed the same but was shrinked a few pixels to match the rest. Thank you!

I was thinking the Bookmarks Bar was looking a big chonky, thought it might have just been my eyes.

@evanrutledge1
Copy link

Weird. I didn't see that with the bookmarks bar, like, ever. Probably because I was an OG user (I just created my Github acc though), and for a long time used the Chromium 69 - 119

@TeleTimofeya
Copy link

And how did you make such a realistic theme like in the old Google Chrome?

@Darthagnon
Copy link
Author

Darthagnon commented May 9, 2024

And how did you make such a realistic theme like in the old Google Chrome?

er... you know how #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants