Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis support #24

Closed
wincent opened this issue Jun 15, 2016 · 3 comments
Closed

Add Travis support #24

wincent opened this issue Jun 15, 2016 · 3 comments
Labels
chore

Comments

@wincent
Copy link
Owner

wincent commented Jun 15, 2016

No description provided.

@wincent wincent added the chore label Jun 15, 2016
wincent added a commit that referenced this issue Jun 16, 2016
@wincent
Tweak Control.Lens import for better compatibility
c9efe9d 
One of the CI runs blowing up:

    /home/travis/build/wincent/docvim/lib/Text/Docvim/Optimize.hs:3:1: Warning:
        Module ‘Control.Lens’ does not export ‘Empty’
    <no location info>:
    Failing due to -Werror.

Source: https://travis-ci.org/wincent/docvim/jobs/138094062

I'm going to turn off `-Werror` in CI and keep it locally, but in the meantime I
think I can get compatibility with a wider range of Lens versions if I switch
the import to not mention `Empty`.

See also: #24
wincent added a commit that referenced this issue Jun 16, 2016
@wincent
Don't use -Werror in Stack
eac6a12 
I intend this to mostly be a local feedback tool, so I *think* that defaulting
this to off is right call. I fixed the specific build failure cited below anyway
in c9efe9d, but I think it's ok to turn off `-Werror` in Stack because
other "real" errors will still be errors; these are just warnings.

I've added explicit `-Werror` to all my wrapper scripts except `bin/repl`, which
is not "build-like" and I want to be lenient. (I actually meant to make it more
lenient in the future by deferring type errors with `-fdefer-type-errors`.

See:

- #24
- https://travis-ci.org/wincent/docvim/jobs/138094062
- https://www.reddit.com/r/haskell/comments/4np0l2/a_ghci_annoyance_wondering_if_anyones_else_also/
wincent added a commit that referenced this issue Jun 16, 2016
@wincent
Fix for HFS+ brain-deadness
ee97dbd 
Case-insensitivity strikes again. I suspect this will fix some build failures.
See:

#24
@wincent
Copy link
Owner Author

wincent commented Jun 16, 2016

Some issues

GHC 7.10.3

setup-Simple-Cabal-1.22.5.0-x86_64-linux-ghc-7.10.3: can't find source for
Tasty in dist/build/tasty/tasty-tmp, tests, lib

Suspect HFS+ case-sensitivity issue, because similar test passes on OS X.

stack default

setup-Simple-Cabal-1.24.0.0-ghc-8.0.1: can't find source for Tasty in
.stack-work/dist/x86_64-linux/Cabal-1.24.0.0/build/tasty/tasty-tmp, tests, lib

Likely same issue.

stack 7.10.3

setup-Simple-Cabal-1.22.5.0-ghc-7.10.3: can't find source for Tasty in
.stack-work/dist/x86_64-linux/Cabal-1.22.5.0/build/tasty/tasty-tmp, tests, lib

Same.

stack 7.10.2

/home/travis/build/wincent/docvim/lib/Text/Docvim/Optimize.hs:3:1: Warning:
    Module ‘Control.Lens’ does not export ‘Empty’
<no location info>: 
Failing due to -Werror.

Want to not use -Werror in Stack builds (but will use it locally in wrapper scripts). But also can change the hiding line in Optimize.hs which is causing that error.

GHC 7.8.4

rejecting: base-4.7.0.2/installed-bfd... (conflict: docvim => base>=4.8 &&
<4.10)

Could try relaxing the lower boundary and see if it builds.

stack 7.8.4

      base: needed (>=4.8 && <4.10), 4.7.0.2 found (latest applicable is 4.9.0.0)

Same issue as above.

GHC 7.6.3

rejecting: base-4.6.0.1/installed-8aa... (conflict: docvim => base>=4.8 &&
<4.10)

Doubt things will still work with the lower boundary set that low, but can give it a try.

@wincent
Copy link
Owner Author

wincent commented Jun 16, 2016

stack 7.8.4 osx

      base: needed (>=4.8 && <4.10), 4.7.0.2 found (latest applicable is 4.9.0.0)

stack 7.10.2 osx

    Module ‘Control.Lens’ does not export ‘Empty’
<no location info>: 
Failing due to -Werror.

And the others look like more of the same...

@wincent
Copy link
Owner Author

wincent commented Jun 16, 2016

See also #27 and #26, which test out the impact of relaxing the base lower bound.

@wincent wincent closed this as completed Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wincent