Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in OEP wind_turbine_library causes fails in windpowerlib #100

Closed
uvchik opened this issue Mar 10, 2020 · 8 comments
Closed

Error in OEP wind_turbine_library causes fails in windpowerlib #100

uvchik opened this issue Mar 10, 2020 · 8 comments
Assignees

Comments

@uvchik
Copy link
Member

uvchik commented Mar 10, 2020

The turbine with turbine_id 152 in supply/wind_turbine_library is corrupt:

In power_curve_wind_speeds you will find duplicate values causing errors in the data processing of the windpowerlib as the windspeed are used as columns.

[3.0, 3.5, 4.0, 4.5, 4.8, 5.0, 5.2, 6.0, 6.2, 6.4, 6.5, 6.6, 6.6, 6.7, 6.8, 6.9, 6.9, 6.9, 6.9, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.5, 8.0, 8.5, 9.0, 9.5, 10.0, 10.2, 10.5, 10.6, 10.7, 10.7, 10.7, 10.8, 10.8, 10.8, 10.8, 10.8, 10.8, 10.8, 10.8, 10.8, 10.9, 11.0, 11.2, 11.5, 11.8, 12.0, 13.0, 14.0, 15.0, 17.5, 20.0, 22.5, 25.0]
@Ludee
Copy link
Collaborator

Ludee commented Mar 10, 2020

Thanks for testing and spotting!
@christian-rli please fix this and document here: OpenEnergyPlatform/data-preprocessing#28

@uvchik
Copy link
Member Author

uvchik commented Mar 10, 2020

@christian-rli could you please just remove the line, because this bug can make the windpowerlib unusable. Most users will not be able to fix it.

For the future we should think of how to avoid such issues.

@Ludee
Copy link
Collaborator

Ludee commented Mar 10, 2020

I removed the line by hand since @christian-rli is not available this week.

@Ludee Ludee closed this as completed Mar 10, 2020
@uvchik
Copy link
Member Author

uvchik commented Mar 10, 2020

We could add a column verified to the table. In the windpowerlib we will only use turbines with verified is True by default. If you want to use a not verified turbine you have to pass a special parameter like verified_only=False. So a corrupt data set will not break the windpowerlib but if you want to use a new data set it is still possible. If everything is fine we can set verified to true.

@uvchik uvchik reopened this Mar 10, 2020
@uvchik
Copy link
Member Author

uvchik commented Mar 10, 2020

I removed the line by hand since @christian-rli is not available this week.

Thank you @Ludee 👍

@Ludee
Copy link
Collaborator

Ludee commented Mar 11, 2020

That's a good idea. Another idea is to validate the data in the windpowerlib when importing.

@uvchik
Copy link
Member Author

uvchik commented Mar 11, 2020

That's a good idea. Another idea is to validate the data in the windpowerlib when importing.

I think we should do both. The windpowerlib should not be vulnerable by corrupt data sets and the oep should make sure that it does not provide corrupt data.

@uvchik
Copy link
Member Author

uvchik commented Apr 7, 2020

I addressed this issue in PR #101 and added an issue in the OEP-repository.

@uvchik uvchik closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants