Initial project #1
Conversation
src/config/config.development.yml
Outdated
| - host: '127.0.0.1' | ||
| port: 7000 | ||
| - host: '127.0.0.1' | ||
| port: 7000 |
package.json
Outdated
| "cluster:start": "browser-refresh src/cluster.js" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", |
docker-compose.yml
Outdated
| POSTGRES_PASSWORD: 'postgres' | ||
| POSTGRES_DB: 'windbreaker' | ||
| ports: | ||
| - '5432:5432' |
There was a problem hiding this comment.
You may encounter errors when running CI with exposed ports like this.
package.json
Outdated
| "test:integration": "docker-compose run test npm run test:docker:integration", | ||
| "test:docker:ci": "npm run lint && nyc ava test/unit test/integration --verbose", | ||
| "test:docker:integration": "nyc ava test/unit test/integration --verbose", | ||
| "start": "browser-refresh src/server.js", |
There was a problem hiding this comment.
Due to a limitation of the docker image we use for rediscluster, you won't be able to actually execute commands on the cluster from outside of docker.
There was a problem hiding this comment.
It's actually a limitation of redis cluster in NAT'd environments. Redis cluster will advertise IPs/ports which are routable from inside the docker network, but the host machine has no idea how to route to those addresses. The initial connect will work, but any requests which try to look up a key that is on a different master will result in the client getting redirected to an address which will be unroutable from the perspective of the host. Related: redis/redis#2527
package.json
Outdated
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "name": "windbreaker-server", | |||
src/producer/index.js
Outdated
|
|
||
| startProducer() | ||
| // .then(() => { | ||
| // TODO: Handle all messages in async queue here |
There was a problem hiding this comment.
Don't forget to reattach an error listener to the new producer that gets created.
src/server.js
Outdated
| }) | ||
|
|
||
| process.on('unhandledException', function (err) { | ||
| // TODO: Log this to a database |
There was a problem hiding this comment.
For situations like this, there's not real guarantee that we will have access to a our database at this point. Using a monitor or logging system like newrelic or scaylr would be slightly more reliable.
package.json
Outdated
| "author": "", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "custom-logger": "^0.3.1", |
This is not ready for a very formal review. There are no tests and things aren't completely working. I'm opening this PR as more of a way to share my current directory structure. I propose that we follow something similar to this.