Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/command line #1028

Merged
merged 3 commits into from May 8, 2018
Merged

Bugfix/command line #1028

merged 3 commits into from May 8, 2018

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented May 8, 2018

Fixes the problem with issue #1019.

It will now save the focus state of the command text field an refocus once it's enabled again.
Also fixed a small issue where the left and right arrow keys weren't usable.

…cessfully sent. Also made it more clear the command field isn't enabled by disabling the label too.

Activated the left and right keys so that it's possible to move the cursor in the text field.
@breiler breiler requested a review from winder May 8, 2018 09:56
@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #1028 into master will decrease coverage by 0.02%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1028      +/-   ##
============================================
- Coverage     29.79%   29.77%   -0.03%     
  Complexity     1021     1021              
============================================
  Files           143      143              
  Lines         10049    10060      +11     
  Branches        913      917       +4     
============================================
+ Hits           2994     2995       +1     
- Misses         6767     6777      +10     
  Partials        288      288
Impacted Files Coverage Δ Complexity Δ
...salgcodesender/uielements/panels/CommandPanel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lwinder/universalgcodesender/model/GUIBackend.java 45.75% <0%> (ø) 57 <0> (ø) ⬇️
...esender/uielements/components/CommandTextArea.java 65.67% <25%> (-8.47%) 10 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d276f...be5ad77. Read the comment docs.

@winder winder merged commit eaefc41 into winder:master May 8, 2018
@breiler breiler deleted the bugfix/command-line branch May 28, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants