#1158 Enhance ProcessorRemover to Replacer #1642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…original PatternRemover. Uses sed "s/regex/replacewith" for Replacer OR regex "regex" to give the original behaviour. No changes to the JSON storage of settings.
…original PatternRemover. Uses sed "s/regex/replacewith" for Replacer OR regex "regex" to give the original behaviour. No changes to the JSON storage of settings.
…original PatternRemover. Uses sed "s/regex/replacewith" for Replacer OR regex "regex" to give the original behaviour. No changes to the JSON storage of settings.
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
… syntax and %macro% expansion within the Replacer
|
It fails build here, but builds correctly without cyclic dependency (which is removed from the code) using the build script on my local machine. I will admit now to not knowing what is happening - over to someone with higher knowledge to point me/correct me/whatever. |
|
Will take a fresh fork and try submitting again. Frustrating, but it is something to try... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1158 Enhance ProcessorRemover to Replacer. Macro expansion disabled (code commented out) until cyclic dependency issue can be overcome - will need someone with more architectural understanding to help address this.