Add missing actions #988
Add missing actions #988
Conversation
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
============================================
- Coverage 29.72% 29.69% -0.03%
- Complexity 979 981 +2
============================================
Files 138 139 +1
Lines 9761 9778 +17
Branches 893 889 -4
============================================
+ Hits 2901 2904 +3
- Misses 6575 6590 +15
+ Partials 285 284 -1
Continue to review full report at Codecov.
|
| @Override | ||
| public void actionPerformed(ActionEvent e) { | ||
| try { | ||
| backend.resetCoordinateToZero('Z'); |
There was a problem hiding this comment.
I know this is the old code, but I would love to see a enum or constant instead of using magic char.
| @@ -4,7 +4,20 @@ if [ -f /Applications/Inkscape.app/Contents/Resources/bin/inkscape ]; then | |||
| alias inkscape="/Applications/Inkscape.app/Contents/Resources/bin/inkscape" | |||
| fi | |||
|
|
|||
| # Make sure nobody is using black instead of blackish | |||
There was a problem hiding this comment.
@breiler this PR is basically impossible to review now, I tweaked the export script to generate the _dark and _disabled_dark files. It does make the connect icon a little weird though, it will now have a teal border in dark mode since dark/_disabled_dark versions will be created.
There was a problem hiding this comment.
@dastultz I noticed that some icons used black and some used a very dark gray. Is this intentional? I converted everything to use the same dark gray color, the colors can be updated pretty easily now if we want to experiment.
There was a problem hiding this comment.
I'm responsible for the dark gray color which is stolen from MacOSX. I wanted it to be more consistent with the dark gray panel and the menu text colors. If you don't approve I can change it back to black.
There was a problem hiding this comment.
They both look black to me, I was just trying to make it consistent.
Add missing actions:
This resolves #984