Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-add ability to customize box shadow size #631

Merged
merged 1 commit into from
Dec 27, 2021
Merged

feat: re-add ability to customize box shadow size #631

merged 1 commit into from
Dec 27, 2021

Conversation

Techassi
Copy link
Member

I was a little to eager to move all .shadow-x size classes to statically defined classes. This removed the ability to customize / extend box shadow sizes like #593 (comment) mentions.

This PR re-adds this functionality and also enables it to be used alongside the new colored box shadows.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #631 (74c9484) into main (ebd5f1d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   88.16%   88.17%   +0.01%     
==========================================
  Files          57       57              
  Lines        4850     4855       +5     
  Branches     1032     1034       +2     
==========================================
+ Hits         4276     4281       +5     
  Misses        311      311              
  Partials      263      263              
Impacted Files Coverage Δ
src/config/base.ts 75.00% <ø> (ø)
src/lib/utilities/static.ts 100.00% <ø> (ø)
src/utils/completions.ts 100.00% <ø> (ø)
src/lib/utilities/dynamic.ts 94.55% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd5f1d...74c9484. Read the comment docs.

@antfu antfu merged commit c643798 into windicss:main Dec 27, 2021
@Techassi Techassi deleted the custom-box-shadow-size branch December 27, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants