Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StyleSheet sort makes plugin doesn't work as expected (#666) #669

Merged
merged 1 commit into from Feb 22, 2022

Conversation

avxit
Copy link
Contributor

@avxit avxit commented Jan 19, 2022

This should fix #666. The solution is create an additional StyleSheet for plugin, separate sort for each StyleSheet then extend.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #669 (1bba0c7) into main (dec4a6a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   88.18%   88.19%           
=======================================
  Files          57       57           
  Lines        4868     4869    +1     
  Branches     1037     1037           
=======================================
+ Hits         4293     4294    +1     
  Misses        311      311           
  Partials      264      264           
Impacted Files Coverage Δ
src/lib/preflight.ts 89.18% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec4a6a...1bba0c7. Read the comment docs.

@antfu antfu merged commit f512a3c into windicss:main Feb 22, 2022
@avxit avxit deleted the fix-plugin-stylesheet-sort branch February 22, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting algorithm problem
3 participants