Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align outline utility classes #716

Merged
merged 4 commits into from Feb 26, 2022
Merged

feat: align outline utility classes #716

merged 4 commits into from Feb 26, 2022

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 26, 2022

#593 (comment) mentions to adjust the outline utilities. This PR aligns them.

Examples

.outline-2 {
  outline-width: 2px;
}

.outline-red-500 {
  --tw-outline-opacity: 1;
  outline-color: rgba(153, 27, 27, var(--tw-outline-opacity));
}

.outline-red-800\/50 {
  --tw-outline-opacity: 0.5;
  outline-color: rgba(153, 27, 27, var(--tw-outline-opacity));
}

.outline {
  outline-style: solid;
}

.outline-dashed {
  outline-style: dashed;
}

.outline-offset-1 {
  outline-offset: 1px;
}

.outline-offset-2 {
  outline-offset: 2px;
}

/* Backwards compatibility */
.outline-opacity-50 {
  --tw-outline-opacity: 0.5;
}

References

EDIT: Once merged I will also update the docs.

@Techassi Techassi requested a review from antfu February 26, 2022 01:43
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #716 (27671e6) into main (f5ef5f5) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   88.13%   88.14%           
=======================================
  Files          57       57           
  Lines        4872     4884   +12     
  Branches     1040     1037    -3     
=======================================
+ Hits         4294     4305   +11     
  Misses        312      312           
- Partials      266      267    +1     
Impacted Files Coverage Δ
src/config/base.ts 75.00% <ø> (ø)
src/lib/utilities/static.ts 100.00% <ø> (ø)
src/lib/utilities/dynamic.ts 94.95% <90.10%> (+0.38%) ⬆️
src/plugin/forms/index.ts 100.00% <100.00%> (ø)
src/utils/completions.ts 100.00% <100.00%> (ø)
src/utils/color.ts 74.54% <0.00%> (-3.64%) ⬇️
src/lib/utilities/handler.ts 67.79% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ef5f5...27671e6. Read the comment docs.

@antfu antfu merged commit 321b2d6 into main Feb 26, 2022
@antfu antfu deleted the outlines branch February 26, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants