Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment on double-spend attack vector in approveData #270

Merged
merged 1 commit into from Oct 2, 2017
Merged

Add comment on double-spend attack vector in approveData #270

merged 1 commit into from Oct 2, 2017

Conversation

nberger
Copy link
Contributor

@nberger nberger commented Oct 2, 2017 •
edited

Comment taken from zeppelin's approve method in OpenZeppelin/openzeppelin-contracts#446

Fixes #246

@nberger nberger requested a review from AugustoL October 2, 2017 12:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.012% when pulling d7144db on add-comment-on-double-spend-attack-vector into 04faecd on master.

@nberger nberger merged commit 9164e16 into master Oct 2, 2017
@nberger nberger deleted the add-comment-on-double-spend-attack-vector branch October 2, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustoL AugustoL AugustoL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nberger @coveralls @AugustoL