Make approve method compliant with ERC20 #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jakub-wojciechowski! Could you add to the documentation of |
|
Sure @frangio, that's a very good idea. |
|
Ready to merge, @jakub-wojciechowski can you rebase on |
frangio
added a commit
that referenced
this pull request
Sep 18, 2017
Make approve method compliant with ERC20
|
Merged manually! Thanks a lot @jakub-wojciechowski. |
nberger
added a commit
to windingtree/lif-token
that referenced
this pull request
Oct 2, 2017
Comment taken from zeppelin's approve method in OpenZeppelin/openzeppelin-contracts#446
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
Make approve method compliant with ERC20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing an issue #438 as we reached the conclusion that it's best to unconditionally follow the ERC20 specs