Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in getfile command. Add full weblink in the response message #357

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

gmag11
Copy link
Contributor

@gmag11 gmag11 commented Jan 25, 2024

There was a couple typos in JS and example code for getfile

@gmag11
Copy link
Contributor Author

gmag11 commented Jan 25, 2024

I did not plan to include the last commit before clarifying #358. Anyway, in my side it seems to be working. Maybe we should add a note into the README pointing that weblink is included in the response from getFile.

@gmag11 gmag11 changed the title Typo fix in getfile command Typo fix in getfile command. Add full weblink in the response message Jan 25, 2024
@windkh
Copy link
Owner

windkh commented Jan 26, 2024

@gmag11 please run
npm run lint
from the command line and fix the issues (see red build above)

And then if you don't mind: extend the readme please

@windkh windkh merged commit bd4bd2c into windkh:master Jan 30, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants