fix: Allow run git for Deno (#2789)

windmill-labs · Dec 6, 2023 · 8ad8d20 · 8ad8d20
1 parent 0b13f2d
commit 8ad8d20
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/backend/windmill-worker/src/deno_executor.rs b/backend/windmill-worker/src/deno_executor.rs
@@ -116,6 +116,7 @@ pub async fn generate_deno_lock(
         .args(vec![
             "cache",
             "--unstable",
+            "--allow-run='git'", // TODO: make this configurable from an env variable when needed
             "--lock=lock.json",
             "--lock-write",
             "--import-map",

diff --git a/frontend/src/lib/components/DisplayResult.svelte b/frontend/src/lib/components/DisplayResult.svelte
@@ -4,7 +4,7 @@
 	import TableCustom from './TableCustom.svelte'
 	import { copyToClipboard, roughSizeOfObject, truncate } from '$lib/utils'
 	import { Button, Drawer, DrawerContent } from './common'
-	import { ClipboardCopy, Download, Expand } from 'lucide-svelte'
+	import { ClipboardCopy, Download, Expand, PanelRightOpen } from 'lucide-svelte'
 	import Portal from 'svelte-portal'
 	import ObjectViewer from './propertyPicker/ObjectViewer.svelte'
 	import S3FilePicker from './S3FilePicker.svelte'
@@ -312,19 +312,19 @@
 					on:click={() => {
 						s3FileViewer?.open?.(result)
 					}}
-					>s3 explorer
+					><span class="flex items-center gap-1"><PanelRightOpen size={12} />open preview</span>
 				</button>
 			</div>
 		{:else if !forceJson && resultKind == 's3object-list'}
 			<div class="absolute top-1 h-full w-full">
 				{#each result as s3object}
 					<Highlight class="" language={json} code={toJsonStr(s3object).replace(/\\n/g, '\n')} />
 					<button
-						class="text-secondary underline text-2xs whitespace-nowrap"
+						class="text-secondary text-2xs whitespace-nowrap"
 						on:click={() => {
 							s3FileViewer?.open?.(s3object)
 						}}
-						>s3 explorer
+						><span class="flex items-center gap-1"><PanelRightOpen size={12} />open preview</span>
 					</button>
 				{/each}
 			</div>

diff --git a/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte b/frontend/src/lib/components/propertyPicker/ObjectViewer.svelte
@@ -7,6 +7,7 @@
 	import WarningMessage from './WarningMessage.svelte'
 	import { NEVER_TESTED_THIS_FAR } from '../flows/models'
 	import Portal from 'svelte-portal'
+	import { PanelRightOpen } from 'lucide-svelte'
 	import S3FilePicker from '../S3FilePicker.svelte'
 
 	export let json: any
@@ -137,7 +138,7 @@
 						on:click={() => {
 							s3FileViewer?.open?.(json)
 						}}
-						>s3 explorer
+						><span class="flex items-center gap-1"><PanelRightOpen size={12} />open preview</span>
 					</button>
 				{/if}
 			{/if}