Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm() does not respect .tiltignore file #2602

Closed
digger18 opened this issue Nov 26, 2019 · 4 comments
Closed

helm() does not respect .tiltignore file #2602

digger18 opened this issue Nov 26, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@digger18
Copy link

digger18 commented Nov 26, 2019

I have a helm chart which has subcharts in it (using requirements.yaml).
In my .tiltignore file I added *.tgz and placed it next to my Tiltfile.
After I do helm dep update in the helm chart directory (which fetches the subcharts as .tgz files to charts/ directory), Tilt enters a restart loop because it detects (and not ignoring) the newly modified/added .tgz charts.

@nicks
Copy link
Member

nicks commented Nov 26, 2019

thanks for the report! let me poke at this a bit and see if i can figure out what's happening

@nicks nicks self-assigned this Nov 26, 2019
@nicks nicks added the bug Something isn't working label Nov 26, 2019
@nicks
Copy link
Member

nicks commented Nov 26, 2019

OK, I double-checked, and I think Tilt is working correctly here.

To make sure that charts don't trigger rebuilds, you need to add this to your .tiltignore

**/*.tgz
**/charts
**/tmpcharts

.tiltignore works like .dockerignore, and doesn't match subdirectories by default.

I'm going to

  • add a note in the Helm documentation on this, since I expect other people will want to copy this stanza, and
  • make sure we have a second bug about detecting infinte reload

@nicks
Copy link
Member

nicks commented Nov 26, 2019

added a note on this to the helm guide:
https://docs.tilt.dev/helm.html

@bobjackman
Copy link

Possible solution: #3404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants