ci: check goimports instead of gofmt #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@landism should we merge this in? |
Yes, probably, once I have time to make it actually work. It's not currently actually running goimports. |
maiamcc
approved these changes
Jun 17, 2019
| @@ -111,11 +114,9 @@ errcheck: | |||
| timing: install | |||
| ./scripts/timing.py | |||
|
|
|||
| WIRE_PATHS = engine cli synclet sail/client | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the churn on separating groups of imports.
Unfortunately, it won't completely eliminate it. goimports ensures that types of imports are in separate groups, but it doesn't not ensure that they are grouped minimally (i.e., splitting tilt imports into two, or putting each import into its own group is legit by goimports standards).
You'll mostly just want to look at the
Makefileand.circleci/changes. The other changes are simply bringing our source into compliance withgoimports -local github.com/windmilleng/tilt.