Temporary fix for crash at shutdown on Windows tests

windowjs · Feb 13, 2022 · f56ae2f · f56ae2f
1 parent fef9174
commit f56ae2f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/js_api_process.cc b/src/js_api_process.cc
@@ -236,7 +236,12 @@ void ProcessApi::Exit(const v8::FunctionCallbackInfo<v8::Value>& info) {
     code = info[0].As<v8::Int32>()->Value();
   }
   if (Args().headless || code != 0) {
-    std::exit(code);
+    // TODO: this crashes on Github when running tests.
+    // The crash reproes under high contention on debug builds with MSVC.
+    // It's a crash in a destructor at shutdown; using std::quick_exit to
+    // bypass atexit callbacks as a temporary workaround.
+    // std::exit(code);
+    std::quick_exit(code);
   } else {
     JsApi* api = JsApi::Get(info.GetIsolate());
     glfwSetWindowShouldClose(api->glfw_window(), GLFW_TRUE);