Use SkSurfaces only for rendering #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaodasilva
commented
Jan 21, 2022
joaodasilva
commented
- single GLFWwindow, no offscreen GLFWwindow contexts for canvas instances
- removed SetCurrentContext; single GL context active all the time on main thread
- all draws through Skia, including to framebuffer 0 (fixes Fix glClear not working on some drivers #35)
- single call to clearRect makes the window transparent (fixes Transparent background for the canvas #50)
- removed gl.cc and gl.h (GL texture drawing utilities)
- removed --log and --child-log; logs enabled by default now
- trigger requestAnimationFrames scheduled inside 'resize' events on same frame
- save transforms stack across resizes (not just the most recent transform)
- removed hacks to sync Skia to external GL calls
- Updated canvas tests to run on 400x200. Some systems have a minimal window width larger than 200 on high DPI.
* single GLFWwindow, no offscreen GLFWwindow contexts for canvas instances * removed SetCurrentContext; single GL context active all the time on main thread * all draws through Skia, including to framebuffer 0 * single call to clearRect makes the window transparent (fixes #50) * removed gl.cc and gl.h (GL texture drawing utilities) * removed --log and --child-log; logs enabled by default now * trigger requestAnimationFrames scheduled inside 'resize' events on same frame * save transforms stack across resizes (not just the most recent transform) * removed hacks to sync Skia to external GL calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.