Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new project UIData to reference WinUIXamlMediaData. #102

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

plaiMS
Copy link
Contributor

@plaiMS plaiMS commented Apr 23, 2019

This is the first part of a refactoring that will enable code to reference the new WinUIXamlMediaData namespace. Adding a new project UIData to reference WinUIXamlMediaData and will eventually move all code under source/WinCompData that needs to reference WinUIXamlMediaData to UIData.

In this PR, UIData includes ObjectGraph.cs and Graph.cs which is a copy of the ones in source/WinCompData/Tools, except that the UIData/Tools/[Object]Graph.cs has the new UIData namespace and it references WinUIXamlMediaData.

In the next PR, the original ObjectGraph.cs and Graph.cs under source/WinCompData/Tools will be deleted and all necessary files will be moved to UIData.

@dnfclas
Copy link

dnfclas commented Apr 23, 2019

CLA assistant check
All CLA requirements met.

simeoncran
simeoncran previously approved these changes Apr 23, 2019
Copy link
Contributor

@simeoncran simeoncran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

sohchatt
sohchatt previously approved these changes Apr 23, 2019
LottieGen/LottieGen.sln Show resolved Hide resolved
@plaiMS plaiMS dismissed stale reviews from sohchatt and simeoncran via 3d9185e April 23, 2019 23:14
Copy link
Contributor

@simeoncran simeoncran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simeoncran simeoncran merged commit c26a039 into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the RefactorForUIXamlMedia branch April 24, 2019 16:53
@michael-hawker michael-hawker added this to the 6.0 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants