Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring to simplify and share code for creating shape visual #131

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Small refactoring to simplify and share code for creating shape visual #131

merged 1 commit into from
Jun 13, 2019

Conversation

simeoncran
Copy link
Contributor

Simplifies the code a bit.
This change was done previously but got lost somewhere.

@simeoncran simeoncran requested a review from plaiMS June 13, 2019 18:47
plaiMS
plaiMS approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@plaiMS plaiMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simeoncran simeoncran merged commit a65dbf2 into master Jun 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the CreateShapeVisualWithChild branch June 13, 2019 19:24
@michael-hawker michael-hawker added this to the 6.0 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaiMS plaiMS plaiMS approved these changes

@eliezerpMS eliezerpMS Awaiting requested review from eliezerpMS

Assignees

@plaiMS plaiMS

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simeoncran @plaiMS @michael-hawker