Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the generated CX classes public. This allows them to be used in XAML #138

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

simeoncran
Copy link
Contributor

Previously we were always instantiating these from code-behind so the visiblity didn't matter. XAML markup use requires that they are public.

…XAML.

Previously we were always instantiating these from code-behind so the visiblity didn't matter. XAML markup use requires that they are public.
Copy link
Contributor

@eliezerpMS eliezerpMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@simeoncran simeoncran merged commit 2ef1868 into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the CxPublicVisibliity branch July 30, 2019 01:11
@michael-hawker michael-hawker added this to the 6.0 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants