Define a more sensible sorting order for elements in codegen #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h human expectations. This deals better than the old ordering with names that have numbers embedded in them, for example img_001, img_11. The old ordering was particular bad for images provided by designers, resulting in code that looked like it had things in the wrong order.
eliezerpMS
reviewed
Oct 24, 2019
|
|
||
| var xLength = x.Length; | ||
| var yLength = y.Length; | ||
| for (int xi = 0, yi = 0; xi < x.Length && yi < y.Length; xi++, yi++) |
There was a problem hiding this comment.
for (int xi = 0, yi = 0; xi < x.Length && yi < y.Length; xi++, yi++) [](start = 11, length = 69)
I would not mind a comment summarizing the general idea of this for loop. #Closed
added 2 commits
October 24, 2019 10:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order codegen elements in a way that humans would expect.
This deals better than the old ordering with names that have numbers embedded in them,
for example img_001, img_11.
The old ordering was particularly bad for images provided by designers, resulting in code that looked like it had things in the wrong order.