The (perhaps) final part of version-dependent code generation. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2019 17:38
added 2 commits
October 25, 2019 16:29
Previous version didn't work correctly on IDynamicAnimatedVisualSource because it is uses WinRT events which don't seem to be expressable in C# (due to the return value from the _add method). So, this now requires that you have WinUI on your machine, and you may need to adjust the version number in the script.
eliezerpMS
reviewed
Oct 28, 2019
tests/Mocks.cs
Outdated
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Numerics; | ||
| //using System.Numerics.Vectors; |
eliezerpMS
reviewed
Oct 28, 2019
| string bytesFieldName, | ||
| Uri imageUri, | ||
| Wmd.LoadedImageSurface.LoadedImageSurfaceType loadedImageSurfaceType, | ||
| byte[] bytes) |
There was a problem hiding this comment.
Formatting issue? #Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually generates multiple versions of AnimatedVisual classes and switches between them at runtime.