Anti-alias the edges of masks and mattes for a smoother result. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default BorderMode for Visuals is Inherit, and if not specified the value Hard (i.e. not anti-aliased) is passed into the root. The default worked for us previously because the desktop tree sets the BorderMode to Soft and we inherit it so we got Soft behavior everywhere. However the trees created for masks and mattes are not rooted in the desktop, so they were getting set to Hard and some edges looked aliased. This change adds the ability to set the BorderMode and sets it to Soft for the trees created for masks and mattes.
simeoncran
requested review from
eliezerpMS,
scott-moore-ms and
sohchatt
as code owners
simeoncran
commented
Oct 30, 2019
| @@ -670,9 +670,21 @@ Visual TranslateAndApplyMasks(TranslationContext context, ReadOnlySpan<Mask> mas | |||
| // the visual we want captured by the visual surface has a parent to use as the | |||
| // origin of its offsets. | |||
| var sourceIntermediateParent = _c.CreateContainerVisual(); | |||
|
|
|||
| // Because this the root of a tree, the BorderMode is not inherited and | |||
There was a problem hiding this comment.
typo, here and below. #Closed
simeoncran
commented
Oct 30, 2019
source/WinCompData/Visual.cs
Outdated
| @@ -16,6 +16,10 @@ private protected Visual() | |||
| { | |||
| } | |||
|
|
|||
| // Defaults to Inherit. For trees rooted are set to Soft. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default BorderMode for Visuals is Inherit, and if not specified the value Hard (i.e. not anti-aliased) is passed into the root.
The default worked for us previously because the desktop tree sets the BorderMode to Soft and we inherit it so we got Soft behavior everywhere.
However the trees created for masks and mattes are not rooted in the desktop, so they were getting set to Hard and some edges looked aliased.
This change adds the ability to set the BorderMode and sets it to Soft for the trees created for masks and mattes.