Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenu: Add HamburgerVisibility property and fixup tab navigation #1019

Closed
lukasf opened this issue Mar 9, 2017 · 4 comments
Closed

Comments

@lukasf
Copy link
Contributor

lukasf commented Mar 9, 2017

Currently, there is no way to hide the hamburger button and fully show the content without any overlay. We can hide the menu bar by setting DisplayMode to Overlay, but the button is always visible. As a workaround, I have set the HamburgerHeight to zero. But the button is still there and messes up tab navigation. Adding a HamburgerVisibility property will allow us to hide the button itself.

Scenario: Show image in fullscreen mode in an image viewer app, with no controls on screen.

Additionally, I have found that the SplitView control in the control template has tab focus enabled. This does not make sense, we should add IsTabStop="False".

I could create a PR for this if you like.

@deltakosh
Copy link
Contributor

Hey @lukasf!

Most of the time I will not accept a PR for the HamburgerMenu (as the platform team plans to ship one) but for this specific one as it is a small one and it is not easy to do with templating, I'm ok

@deltakosh deltakosh added this to the v1.4 milestone Mar 9, 2017
@lukasf
Copy link
Contributor Author

lukasf commented Mar 9, 2017

Thank you @deltakosh. I will try to make a PR within the next few days.

@lukasf
Copy link
Contributor Author

lukasf commented Mar 9, 2017

Created PR #1020.

@lukasf
Copy link
Contributor Author

lukasf commented Mar 13, 2017

Closing this: PR merged...

@lukasf lukasf closed this as completed Mar 13, 2017
@CommunityToolkit CommunityToolkit locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants