OnDevice markup extension added #2664
Conversation
|
Can you split out the .editorconfig changes? These two PRs from you seem intertwined. It'd be nice maybe if you could start fresh for each with a branch from master with just one commit with the new files? |
| } | ||
| else | ||
| { | ||
| deviceFamily = Windows.System.Profile.AnalyticsInfo.VersionInfo.DeviceFamily; |
There was a problem hiding this comment.
Use our AnalyticsInfo extension method instead of duplicating this logic here with strings, then you can use the enum returned.
There was a problem hiding this comment.
The AnalyticsInfo extension also supports a Tablet value. Should OnDevice have a Tablet property?
Why is a tablet different than a Desktop, only the Touch versus Mouse. What if I connect a mouse to my tablet. I prefer to keep it as it is.
There was a problem hiding this comment.
The AnaliticsInfo extension is part of the SampleApp and must be moved to Microsoft.Toolkit befor it can be used. Do we do this?
There was a problem hiding this comment.
Ah, I forgot it was only part of the sample, I think it'd make sense to move as an Extension in the Microsoft.Toolkit.Uwp namespace.
The tablet mode is a specific mode you can put windows in:
I think it'd be useful to have Tablet as an option.
There was a problem hiding this comment.
Great, I will do that. Thanks
There was a problem hiding this comment.
I have second thoughts about a Tablet property. See my code below. The Text of The Textblock would be Hello when running on Desktop and World when running on Tablet, otherwise it is Hi (Xbox, Holo, IoT, etc). What happens when the user is running the app and then switches from Desktop to Tablet mode. Would the Text have to change on the fly? If yes, how do we implement this?
<TextBlock Text="{helpers:OnDevice Default=Hi, Desktop=Hello, Tablet=World}"
xmlns:helpers="using:Microsoft.Toolkit.Uwp.UI.Extensions.Markup" />
|
@nmetulev I understand that the .editorconfig has to be removed. How do I do that? I'm a daily TFS user and not very experienced in GitHub. Can you help me? |
|
@sonnemaf It'd probably be easiest at this point to checkout a fresh master, create a new branch off of that and copy over your OnDevice file, create the new extension in the Microsoft.Toolkit.Uwp namespace, and update your code and the sample app to use it. |
|
@michael-hawker I will do that. Thanks. |
Issue: #2489
PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information