Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expander fix for tab navigation, tab focus, and high contrast #2788

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

nmetulev
Copy link
Contributor

@nmetulev nmetulev commented Feb 7, 2019

Issue: #2276

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Tab order is broken (content focuses before header)
  • User is able to focus inside overlay when it's not visible
  • A border is visible in high contrast when it's not supposed to

What is the new behavior?

  • Tab order works as expected
  • User is no longer able to focus inside the overlay when it's not visible
  • No border in high contrast mode

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added this to the 5.1 milestone Feb 7, 2019
@azchohfi azchohfi merged commit 3fecfe2 into master Feb 7, 2019
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #2276

@delete-merged-branch delete-merged-branch bot deleted the nmetulev/expander branch February 7, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants