Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App - Redirect links to Microsoft Docs #2799

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Sample App - Redirect links to Microsoft Docs #2799

merged 1 commit into from
Feb 11, 2019

Conversation

avknaidu
Copy link
Member

Issue: #1740 #2387

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

Links do not open.

What is the new behavior?

Links redirect to docs.microsoft.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added this to the 5.1 milestone Feb 11, 2019
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if we should redirect to local specific in future, but don't think we do that for other links now, so this is a good initial fix, thanks!

@michael-hawker michael-hawker merged commit 584d0a8 into CommunityToolkit:master Feb 11, 2019
@windowstoolkitbot
Copy link

This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1740

@avknaidu avknaidu deleted the RelativeLinksFix branch February 12, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants