-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinUI - Test Infra #3482
WinUI - Test Infra #3482
Conversation
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
32c36e6
to
ce85d6e
Compare
…g UI tests in mstest in the future.
ce85d6e
to
b725cb8
Compare
Looks like it can't find a package for the test run?
|
Yeah, that started to happen when I added a reference to the Layout project... I'm fixing this on WinUI first. |
@azchohfi it prompted me to install the app when trying to run the MSTest project tests from VS, is this expected? (Assuming this doesn't happen during the CI?) |
Yes, this is expected. The CI uses the TAEF tests, and installs the cert automatically. It works fine on the CI. |
@azchohfi is there a way we can have the local scripts for MS Test have less enter-to-confirm steps (there were another 3-4 after this first one here)? Is there a reason we can't deploy the app as normal through the VS process? At least it's a one-time step thing, but we should probably document this in our Wiki on this subject too. |
Its a one time only thing, and we have to do it. I don't know if there is a way around it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @azchohfi thanks for getting this all setup!
Can we not see these with the rest of our Unit Tests in the Tests tab under Dev Ops?
I saw the new build step about it reporting, but figured they should be searchable here too, eh?
@@ -3,5 +3,6 @@ | |||
<packageSources> | |||
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" /> | |||
<add key="MyGet" value="https://dotnet.myget.org/F/uwpcommunitytoolkit/api/v3/index.json" protocolVersion="3" /> | |||
</packageSources> | |||
<add key="MUX-Shared" value="https://pkgs.dev.azure.com/ms/microsoft-ui-xaml/_packaging/MUX-Shared/nuget/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do still need this. Its where the package is published. It is a public feed.
@azchohfi do we need to run the |
That wouldn't work. We would need to convert the wtl file to something that ADO understands, and that is not so simple. I know the Terminal team did exactly this, but they are running their tests on Helix, so the logs live there and their code was doing something that was highly coupled with Helix, so I couldn't easily port the code. I think this is a technical debt that we can handle in the future, since its not that simple and adds not much value right now. |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed this is good and we'll continue the discussion on improving the setup of individual tests in #3512
WCT is now sharing WinUI's test infrastructure. This is the continuation of the work on this PR microsoft/microsoft-ui-xaml#3212.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No UI Tests.
What is the new behavior?
Added simple UI Tests for the WCT that use the same shared infrastructure used by WinUI. This will enable us to move controls/helpers in an easier way from the WCT->WinUI in the future.
PR Checklist
Please check if your PR fulfills the following requirements: