Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUP-3246]: WINDUP distribution of CLI with Konveyor themed Reports #80

Merged
merged 10 commits into from Mar 2, 2022

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Jan 18, 2022

@jmle
Copy link
Contributor

jmle commented Feb 22, 2022

Hi @carlosthe19916, the PR looks good, although I would refrain from duplicating the script files - maybe we can create two different script files that just call the first one with different parameters for each build?

@carlosthe19916
Copy link
Member Author

Hi @carlosthe19916, the PR looks good, although I would refrain from duplicating the script files - maybe we can create two different script files that just call the first one with different parameters for each build?

@jmle good suggestion about not duplicating script content. Give me some time and I will fix it, please.

@carlosthe19916
Copy link
Member Author

@jmle Thanks for the previous suggestion. My last commit changed a couple of things:

  • Since the mta-cli and windup-cli have exactly the same content then there is no need to duplicate files. Each Theme will use a different assembly.xml file but the files content will remain as they are.

When you have time please review this PR again to see if there is something to change or it is ready to be merged. You can build the project using mvn clean install for the default MTA theme or mvn clean install -Dcommunity for the Windup theme.

@jmle
Copy link
Contributor

jmle commented Mar 1, 2022

Hi @carlosthe19916, could you please resolve the conflicts? Thanks

# Conflicts:
#	src/main/resources/bin/mta-cli.bat
@jmle jmle merged commit bff3d5b into windup:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants