New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WINDUP-3246]: WINDUP distribution of CLI with Konveyor themed Reports #80
Conversation
Hi @carlosthe19916, the PR looks good, although I would refrain from duplicating the script files - maybe we can create two different script files that just call the first one with different parameters for each build? |
@jmle good suggestion about not duplicating script content. Give me some time and I will fix it, please. |
# Conflicts: # src/main/resources/bin/mta-cli.bat
@jmle Thanks for the previous suggestion. My last commit changed a couple of things:
When you have time please review this PR again to see if there is something to change or it is ready to be merged. You can build the project using |
Hi @carlosthe19916, could you please resolve the conflicts? Thanks |
# Conflicts: # src/main/resources/bin/mta-cli.bat
https://issues.redhat.com/browse/WINDUP-3246