WINDUP-2274 Scripts for local build of CLI and Web UI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
reviewed
Nov 30, 2018
There was a problem hiding this comment.
Happy with changes, scripts run successfully.
Is it worth specifying in the main git title page that you run these scripts from your umbrella 'Projects' dir using eg
./windup-local-build-scripts/build_web.sh
I tried to run them from the windup-local-build-scripts root and of course they failed from there.
mrizzi
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
It worked for me as well, thanks @PhilipCattanach 👍
I would only add, as @m-brophy suggested, the instructions on how to run the scripts in the README.md file of this project
mrizzi
reviewed
Dec 19, 2018
There was a problem hiding this comment.
@PhilipCattanach I've just added 2 changes to format the commands: if you accept them, then i'll merge this PR.
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Co-Authored-By: PhilipCattanach <31246010+PhilipCattanach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the scripts from the parent folder to your cloned repositories
The build_cli.sh expects the windup, windup-rulesets and windup-distribution projects to have been cloned.
The build_web.sh expects the windup-web, windup-openshift and windup-web-distribution projects to have been cloned.
For the build_web.sh please ensure that you have the docker daemon running