WINDUP-1824: Windup Maven Plugin does not include nexus indexes to ignore known jars #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizzi
reviewed
May 4, 2018
| if (!windupHomeSpecified) | ||
| { | ||
| downloadAndUnzipRules(); | ||
| windupConfiguration.addDefaultUserRulesDirectory(PathUtil.getWindupRulesDir()); |
There was a problem hiding this comment.
I think this line should be out of the the if block because if there's the windupHome property, then the rules folder from the Windup home is not added to the set of rules folders.
|
Fixed. Thanks for the review @mrizzi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WINDUP-1824
This adds the option to specify windupHome. Specifying windupHome will cause it to use the rules from there as well as the nexus indexes from there instead of the ones that are downloaded.
There are other ways of accomplishing this, so feel free to disagree if you would prefer an alternative approach.