Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Choose the template paragraph #11

Merged
merged 2 commits into from Jan 22, 2019
Merged

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Dec 6, 2018

Added Choose the template paragraph
Changed the sample commands to use the web-template-empty-dir-executor.json template

I think it's useful, to evaluate the final result, to have a look also the the rendered file in my branch https://github.com/mrizzi/windup-openshift/blob/WINDUP-2258-readme/README.md

This depends on #10

Added `Choose the template` paragraph
Changed the sample commands to use the `web-template-empty-dir-executor.json` template
@PhilipCattanach
Copy link

I think it would be better we used the all capitals REST acronym.
Regarding the web-template.json 'but it requires more persistent volume resources since it adds a persistent volume also to the executor pod'. It is not clear what benefit the persistent volume to the executer pod brings. Why would a user choose to use this template over the recommended one? If there isn't a good reason for retaining it perhaps we should consider deleting it.

@mrizzi mrizzi merged commit ed66c07 into windup:master Jan 22, 2019
@mrizzi mrizzi deleted the WINDUP-2258-readme branch January 22, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants