WINDUPRULE-450 Add rule for removed xslt method

windup · Feb 21, 2020 · bb9fe92 · bb9fe92
1 parent 40e9526
commit bb9fe92
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/rules-reviewed/camel3/camel2/java-generic-information.windup.xml b/rules-reviewed/camel3/camel2/java-generic-information.windup.xml
@@ -194,7 +194,7 @@
                 </javaclass>
             </when>
             <perform>
-                <hint title="`oorg.apache.camel.util.toolbox.AggregationStrategies` has been moved" effort="1" category-id="mandatory">
+                <hint title="`org.apache.camel.util.toolbox.AggregationStrategies` has been moved" effort="1" category-id="mandatory">
                     <message>
                         The class `org.apache.camel.util.toolbox.AggregationStrategies` has been moved to `org.apache.camel.builder.AggregationStrategies`.
                     </message>
@@ -404,5 +404,19 @@
                 </hint>
             </perform>
         </rule>
+    <rule id="java-generic-information-00021">
+            <when>
+                <javaclass references="org.apache.camel.util.toolbox.AggregationStrategies.xslt({*})" >
+                    <location>METHOD_CALL</location>
+                </javaclass>
+            </when>
+            <perform>
+                <hint title="xslt method was removed from `org.apache.camel.util.toolbox.AggregationStrategies`" effort="1" category-id="mandatory">
+                    <message>xslt method was removed from `org.apache.camel.util.toolbox.AggregationStrategies`. Instead use the `XsltAggregationStrategy` from `camel-xslt` JAR directly`</message>
+                    <link href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"
+                            title="Camel 3 - Migration Guide"/>
+                </hint>
+            </perform>
+        </rule>
     </rules>
 </ruleset>
diff --git a/rules-reviewed/camel3/camel2/tests/data/java-generic-information/RouteBuilder.java b/rules-reviewed/camel3/camel2/tests/data/java-generic-information/RouteBuilder.java
@@ -25,6 +25,7 @@
 import org.apache.camel.builder.xml.InvalidXPathExpression;
 
 import org.apache.camel.processor.validation.PredicateValidationException;
+import org.apache.camel.util.toolbox.AggregationStrategies;
 
 /**
  * A Camel Java DSL Router
@@ -58,7 +59,11 @@ public void configure() {
             from("vm:bar?concurrentConsumers=5")
             .to("validator:org/apache/camel/component/validator/schema.xsd?headerName=headerToValidate&amp;failOnNullHeader=false");
     }
-}
+
+    public static void main(String[] args) throws Exception {
+        Object ag = AggregationStrategies.xslt("somePath");
+    }
+
     @Override
     public void configure(CustomRouteBuilder configuration) throws Exception{
         if (configuration.getIntercepted() != null) {

diff --git a/rules-reviewed/camel3/camel2/tests/java-generic-information.windup.test.xml b/rules-reviewed/camel3/camel2/tests/java-generic-information.windup.test.xml
@@ -117,7 +117,7 @@
             <rule id="java-generic-information-00008-test">
                 <when>
                     <not>
-                        <iterable-filter size="1">
+                        <iterable-filter size="2">
                             <hint-exists message="The class `org.apache.camel.util.toolbox.AggregationStrategies` has been moved to `org.apache.camel.builder.AggregationStrategies`."/>
                         </iterable-filter>
                     </not>
@@ -257,6 +257,18 @@
                     <fail message="[java-generic-information] Exception moved hint was not found!" />
                 </perform>
             </rule>
+            <rule id="java-generic-information-00021-test">
+                <when>
+                    <not>
+                        <iterable-filter size="1">
+                            <hint-exists message="xslt method was removed from `org.apache.camel.util.toolbox.AggregationStrategies.*"/>
+                        </iterable-filter>
+                    </not>
+                </when>
+                <perform>
+                    <fail message="[java-generic-information] Exception moved hint was not found!" />
+                </perform>
+            </rule>
         </rules>
     </ruleset>
 </ruletest>