WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usag… (

#366) * WINDUPRULE-381: hibernate 5.1-5.3 migration, RegionFactory class usage review * Update rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com> * Update rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com> * Update rules-reviewed/eap7/eap71/tests/hibernate51-53.windup.test.xml Co-Authored-By: m-brophy <36955467+m-brophy@users.noreply.github.com>
windup · Mar 6, 2019 · bcee7dd · bcee7dd
1 parent 1f6f42b
commit bcee7dd
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 9 deletions.
diff --git a/rules-reviewed/eap7/eap71/hibernate51-53.windup.xml b/rules-reviewed/eap7/eap71/hibernate51-53.windup.xml
@@ -224,17 +224,26 @@
                 </hint>
             </perform>
         </rule>
-        <!--https://issues.jboss.org/browse/WINDUPRULE-381
+        <!--https://issues.jboss.org/browse/WINDUPRULE-381 -->
         <rule id="hibernate51-53-00500">
             <when>
+                <javaclass references="org.hibernate.{className}" >
+                    <location>IMPORT</location>
+                </javaclass>
             </when>
             <perform>
+                <hint title="Hibernate 5.3 - RegionFactory usage" effort="3" category-id="mandatory">
+                    <message>Review usage of classes in `org.hibernate.cache.spi.RegionFactory`, as SPIs for this class has changed.  
+                        See Javadoc for `org.hibernate.cache.spi.RegionFactory` for details.</message>
+                    <link title="Red Hat JBoss EAP 7.2: Migrating from Hibernate ORM 5.1 to Hibernate ORM 5.3" href="https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.2/html-single/migration_guide/#migrating_from_hibernate_5_1_to_5_3"/>
+                    <link title="Javadoc for org.hibernate.cache.spi.RegionFactory" href="https://docs.jboss.org/hibernate/orm/5.3/javadocs/org/hibernate/cache/spi/RegionFactory.html"/>
+                    <tag>hibernate</tag>
+                </hint>
             </perform>
-            <where param="">
-                <matches pattern="" />
+            <where param="className">
+                <matches pattern="(cache.RegionFactory|cache.spi.RegionFactory|cache.spi.AbstractRegionFactory|testing.cache.CachingRegionFactory|cache.spi.support.RegionFactoryTemplate|cache.ehcache.EhCacheRegionFactory|cache.infinispan.InfinispanRegionFactory|cache.infinispan.JndiInfinispanRegionFactory|cache.internal.NoCachingRegionFactory|cache.ehcache.SingletonEhCacheRegionFactory)" />
             </where>
         </rule>
-        -->
         <!--https://issues.jboss.org/browse/WINDUPRULE-382-->
         <rule id="hibernate51-53-00600">
             <when>

diff --git a/rules-reviewed/eap7/eap71/tests/data/data-hibernate51-53/Hibernate515300500.java b/rules-reviewed/eap7/eap71/tests/data/data-hibernate51-53/Hibernate515300500.java
@@ -0,0 +1,17 @@
+import org.hibernate.cache.RegionFactory;
+import org.hibernate.cache.spi.RegionFactory;
+import org.hibernate.cache.spi.AbstractRegionFactory;
+import org.hibernate.testing.cache.CachingRegionFactory;
+import org.hibernate.cache.spi.support.RegionFactoryTemplate;
+import org.hibernate.cache.ehcache.EhCacheRegionFactory;
+import org.hibernate.cache.ehcache.SingletonEhCacheRegionFactory;
+import org.hibernate.cache.infinispan.InfinispanRegionFactory
+import org.hibernate.cache.infinispan.JndiInfinispanRegionFactory;
+import org.hibernate.cache.internal.NoCachingRegionFactory;
+
+public class Hibernate515300500 {
+
+    public void aMethod(String queryString) {
+        queryString.toLowerCase();
+    }
+}
diff --git a/rules-reviewed/eap7/eap71/tests/hibernate51-53.windup.test.xml b/rules-reviewed/eap7/eap71/tests/hibernate51-53.windup.test.xml
@@ -159,20 +159,19 @@
                     <fail message="Hint removed method getAllSecondLevelCacheRegions() not found" />
                 </perform>
             </rule>
-            <!--https://issues.jboss.org/browse/WINDUPRULE-381
+            <!--https://issues.jboss.org/browse/WINDUPRULE-381 -->
             <rule id="hibernate51-53-00500-test">
                 <when>
                     <not>
-                        <iterable-filter size="5">
-                            <hint-exists message="" />
+                        <iterable-filter size="10">
+                            <hint-exists message="Review usage of classes in `org.hibernate.cache.spi.RegionFactory`" />
                         </iterable-filter>
                     </not>
                 </when>
                 <perform>
-                    <fail message="" />
+                    <fail message="RegionFactory references not flagged as required" />
                 </perform>
             </rule>
-            -->
             <!--https://issues.jboss.org/browse/WINDUPRULE-382-->
             <rule id="hibernate51-53-00600-test">
                 <when>