Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WINDUPRULE-1019] adds eap 8 ruleset deprecated-initialcontextfactory… #1044

Merged
merged 1 commit into from Dec 11, 2023
Merged

[WINDUPRULE-1019] adds eap 8 ruleset deprecated-initialcontextfactory… #1044

merged 1 commit into from Dec 11, 2023

Conversation

emmartins
Copy link
Contributor

@emmartins
Copy link
Contributor Author

not ready to merge

@PhilipCattanach
Copy link
Contributor

Hi @emmartins - I think you just need to change the iterable-filter size="3" to size="2" for the first rule test, and remove the second rule test and it should work.

@emmartins
Copy link
Contributor Author

emmartins commented Dec 7, 2023 •
edited

@PhilipCattanach yes but it should be 3, 2 in the class and 1 in the wsdl, so need something more in the rule, to catch the string value reference to the class name. I will investigate later today, just had to switch to something else yesterday.

@emmartins
Copy link
Contributor Author

ready to merge review

@PhilipCattanach
Copy link
Contributor

@emmartins - Thank you. The rules look fine and my tests were successful. I'll merger to master.

@PhilipCattanach PhilipCattanach added auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels Dec 11, 2023
@PhilipCattanach PhilipCattanach merged commit 3898ec3 into windup:master Dec 11, 2023
28 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
@emmartins
[WINDUPRULE-1019] adds eap 8 ruleset deprecated-initialcontextfactory…
aaaa336 
…-is-removed (#1044)

(cherry picked from commit 3898ec3)
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Merged
@github-actions GitHub Actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

PhilipCattanach pushed a commit that referenced this pull request Dec 13, 2023
@github-actions @emmartins
[WINDUPRULE-1019] adds eap 8 ruleset deprecated-initialcontextfactory…
f9a0857 
…-is-removed (#1044) (#1045)

(cherry picked from commit 3898ec3)

Co-authored-by: Eduardo Martins <emartins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Milestone
No milestone
2 participants
@emmartins @PhilipCattanach