Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified the rule to prevent parameterization from trying to coordi… #158

Merged
merged 1 commit into from Jun 7, 2016
Merged

Simplified the rule to prevent parameterization from trying to coordi… #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions rules-reviewed/eap6/weblogic/weblogic.windup.xml
View file
Open in desktop
Expand Up @@ -325,11 +325,8 @@

<rule id="weblogic-017000">
<when>
<or>
<!-- https://issues.jboss.org/browse/WINDUP-615 -->
<filecontent filename="{*}.{ext}" pattern="t3://" />
<filecontent filename="{*}.{ext}" pattern="t3s://" />
</or>
<filecontent filename="{*}.{ext}" pattern="{t3url}" />
</when>
<perform>
<hint title="WebLogic proprietary T3 JNDI binding" effort="3" severity="mandatory">
Expand All @@ -351,6 +348,9 @@
<where param="ext">
<matches pattern="(java|properties|xml)" />
</where>
<where param="t3url">
<matches pattern="t3s?://" />
</where>
</rule>
</rules>
</ruleset>
1 change: 1 addition & 0 deletions src/test/java/org/jboss/windup/rules/tests/WindupRulesTest.java
View file
Open in desktop
Expand Up @@ -319,6 +319,7 @@ private void runWindup(GraphContext context, File baseRuleDirectory, final List<
windupConfiguration.setOutputDirectory(output.toPath());
windupConfiguration.addDefaultUserRulesDirectory(baseRuleDirectory.toPath());
windupConfiguration.setOptionValue(SourceModeOption.NAME, sourceMode);
windupConfiguration.setOffline(true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, but this keeps windup's xml validation from triggering on our test data. That is really unnecessary and sometimes slow.

Obviously, the build-time validation against the rules schema still happens, and that is the important part.

if (StringUtils.isNotBlank(source))
windupConfiguration.setOptionValue(SourceOption.NAME, Collections.singletonList(source));

Expand Down