Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-308 Hibernate ORM 5.0 to Hibernate ORM 5.1 #281

Merged
merged 2 commits into from
Oct 6, 2017

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Oct 5, 2017

Insights for this PR from JIRA WINDUPRULE-308:

  • folder is eap7/eap70/ because, from JIRA, these rules are "Only EAP 7.0 to 7.1"
  • file name hibernate50-51.windup.xml as discussed on IRC
  • source and target also for addressing HIbernate 5.0 -> 5.1 migration
  • rule hibernate50-51-00000 has two <iteration> tags to be able to search for both Byte[] and byte[] within the same rule. I didn't find an easier way to do it but this doesn't imply that there isn't one so any suggestion is really appreciated
  • all links are to "Migration Guide" for EAP 7.1.Beta ("Single-page HTML" version)

Regarding rule hibernate50-51-00000 "Oracle12cDialect maps byte[] and Byte[] to BLOB":

  • tests folder tests/data/data-hibernate50-51/Oracle12cDialect/ verifies that, if org.hibernate.dialect.Oracle12cDialect is set:
    • the rule fires for classes with implicit mapping to byte[] (AnotherPerson), Byte[] (FooPerson) and both of them (Person)
    • the rule do not fire when @Entity is missing (NotEntityPerson)
  • tests folder tests/data/data-hibernate50-51/DB2Dialect/ is for testing that the rule does not fire if the dialect is not set to org.hibernate.dialect.Oracle12cDialect

@mrizzi
Copy link
Member Author

mrizzi commented Oct 5, 2017

e70df59 update as a consequence of comment on WINDUPRULE-308 saying "hibernate.dialect.oracle.prefer_long_raw property was introduced in Hibernate 5.0.8 (HHH-10345). EAP 7.0.0.GA has Hibernate 5.0.9. So it's not changed in EAP 7.1.0.", the rule about "Oracle12cDialect maps byte[] and Byte[] to BLOB" has been moved to hibernate4.windup.xml ruleset as it's part of migration from Hibernate 4 to 5 with its test and all its test files

Copy link
Contributor

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mareknovotny mareknovotny merged commit 44f67a4 into windup:master Oct 6, 2017
@mrizzi mrizzi deleted the JIRA_WINDUPRULE-308 branch October 9, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants