New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winduprule-387 test for the use of TableGenerator #356
winduprule-387 test for the use of TableGenerator #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule locally works.
I provided some suggestions for some improvements.
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to the message and then it's done (once tests are fine)
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
i wait for the builds to finish successfully and then i'll merge it. thanks @jonathanvila |
No description provided.