Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winduprule-387 test for the use of TableGenerator #356

Merged

Conversation

jonathanvila
Copy link
Member

No description provided.

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule locally works.
I provided some suggestions for some improvements.

rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
mrizzi and others added 4 commits March 5, 2019 17:06
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
@jonathanvila jonathanvila requested a review from mrizzi March 6, 2019 08:53
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the message and then it's done (once tests are fine)

rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
mrizzi and others added 2 commits March 7, 2019 14:30
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
@jonathanvila jonathanvila requested a review from mrizzi March 7, 2019 13:31
@mrizzi
Copy link
Member

mrizzi commented Mar 7, 2019

i wait for the builds to finish successfully and then i'll merge it.

thanks @jonathanvila

@mrizzi mrizzi merged commit 9d1826c into windup:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants