Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winduprule-386 hibernate default props #358

Merged
merged 14 commits into from Mar 7, 2019

Conversation

jonathanvila
Copy link
Member

No description provided.

@jonathanvila jonathanvila changed the title Windup 386 hibernate default props winduprule-386 hibernate default props Mar 7, 2019
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is really a good one: well done @jonathanvila, thanks 👍

I've just added the effort that was missing and some small formatting changes.

rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed

rules-reviewed/eap7/eap71/hibernate51-53.windup.xml Outdated Show resolved Hide resolved
Co-Authored-By: jonathanvila <jonathan.vila@gmail.com>
@jonathanvila jonathanvila requested a review from mrizzi March 7, 2019 16:38
@mrizzi mrizzi merged commit 4bd7b9f into windup:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants